lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 06 Feb 2014 14:19:28 +0100 From: Igor Gnatenko <i.gnatenko.brain@...il.com> To: Emil Goode <emilgoode@...il.com> Cc: "David S. Miller" <davem@...emloft.net>, Ming Lei <ming.lei@...onical.com>, Mark Brown <broonie@...aro.org>, Jeff Kirsher <jeffrey.t.kirsher@...el.com>, Glen Turner <gdt@....id.au>, linux-usb@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: asix: fix bad header length bug On Thu, 2014-02-06 at 13:56 +0100, Emil Goode wrote: > The AX88772B occasionally send rx packets that cross urb boundaries > and the remaining partial packet is sent with no header. > When the buffer with a partial packet is of less number of octets > than the value of hard_header_len the buffer is discarded by the > usbnet module. This is causing dropped packages and error messages > in dmesg. > > This can be reproduced by using ping with a packet size > between 1965-1976. > > The bug has been reported here: > > https://bugzilla.kernel.org/show_bug.cgi?id=29082 > > Signed-off-by: Emil Goode <emilgoode@...il.com> Reported-and-tested-by: Igor Gnatenko <i.gnatenko.brain@...il.com> > --- > drivers/net/usb/asix_devices.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c > index 9765a7d..120bb29 100644 > --- a/drivers/net/usb/asix_devices.c > +++ b/drivers/net/usb/asix_devices.c > @@ -455,6 +455,7 @@ static int ax88772_bind(struct usbnet *dev, struct usb_interface *intf) > dev->net->ethtool_ops = &ax88772_ethtool_ops; > dev->net->needed_headroom = 4; /* cf asix_tx_fixup() */ > dev->net->needed_tailroom = 4; /* cf asix_tx_fixup() */ > + dev->net->hard_header_len = 0; /* Partial packets have no header */ > > embd_phy = ((dev->mii.phy_id & 0x1f) == 0x10 ? 1 : 0); > -- -Igor Gnatenko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists