lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 06 Feb 2014 14:39:30 -0600 From: Larry Finger <Larry.Finger@...inger.net> To: Olivier Langlois <olivier@...llion01.com>, linville@...driver.com, chaoming_li@...lsil.com.cn CC: linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Stable <stable@...r.kernel.org> Subject: Re: [PATCH 2/2] rtlwifi: Fix incorrect return from rtl_ps_enable_nic() On 02/01/2014 12:11 AM, Olivier Langlois wrote: > rtl_ps_enable_nic() is called from loops that will loop until this function returns true or a > maximum number of retries is performed. > > hw_init() returns non-zero on error. In that situation return false to > restore the original design intent to retry hw init when it fails. > > Signed-off-by: Olivier Langlois <olivier@...llion01.com> > Cc: Stable <stable@...r.kernel.org> Acked-by: Larry Finger <Larry.Finger.net> Larry > --- > drivers/net/wireless/rtlwifi/ps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/rtlwifi/ps.c b/drivers/net/wireless/rtlwifi/ps.c > index 0d81f76..a56e9b3 100644 > --- a/drivers/net/wireless/rtlwifi/ps.c > +++ b/drivers/net/wireless/rtlwifi/ps.c > @@ -48,7 +48,7 @@ bool rtl_ps_enable_nic(struct ieee80211_hw *hw) > > /*<2> Enable Adapter */ > if (rtlpriv->cfg->ops->hw_init(hw)) > - return 1; > + return false; > RT_CLEAR_PS_LEVEL(ppsc, RT_RF_OFF_LEVL_HALT_NIC); > > /*<3> Enable Interrupt */ > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists