lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Feb 2014 14:09:18 -0800 From: Cong Wang <cwang@...pensource.com> To: Sabrina Dubroca <sd@...asysnail.net> Cc: David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net] netpoll: fix netconsole IPv6 setup On Thu, Feb 6, 2014 at 12:58 PM, Sabrina Dubroca <sd@...asysnail.net> wrote: > 2014-02-06, 12:34:10 -0800, Cong Wang wrote: >> On Thu, Feb 6, 2014 at 9:34 AM, Sabrina Dubroca <sd@...asysnail.net> wrote: >> > net/core/netpoll.c | 4 +++- >> > 1 file changed, 3 insertions(+), 1 deletion(-) >> > >> > diff --git a/net/core/netpoll.c b/net/core/netpoll.c >> > index c03f3de..a664f78 100644 >> > --- a/net/core/netpoll.c >> > +++ b/net/core/netpoll.c >> > @@ -948,6 +948,7 @@ int netpoll_parse_options(struct netpoll *np, char *opt) >> > { >> > char *cur=opt, *delim; >> > int ipv6; >> > + bool ipversion_set = false; >> > >> >> Or initialize 'ipv6' to -1 and then check if it is -1? > > It's overwritten when we parse the remote address. And np->ipv6 is a > bool, so we can't store it there either. > Yeah, I misunderstood the problem. Your fix looks good. Acked-by: Cong Wang <cwang@...pensource.com> For net-next, I think we should change bool np->ipv6 to int np->ip_version, so that we can tell if it is set or not. Thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists