netdev - Re: Question about skb_flow_dissect() and 802.1q/802.1ad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12212434.KMML02VyKq@tuxracer>
Date:	Fri, 07 Feb 2014 21:36:42 +0200
From:	Sergey Popovich <popovich_sergei@...l.ru>
To:	netdev@...r.kernel.org
Subject: Re: Question about skb_flow_dissect() and 802.1q/802.1ad

В письме от 7 февраля 2014 11:11:25 пользователь Eric Dumazet написал:
> On Fri, 2014-02-07 at 20:44 +0200, Sergey Popovich wrote:

> Well, all you need is to properly set network header before calling
> skb_flow_dissect()

It seems, network header pointing properly to network protocol header
(IPv4, IPv6 in my case).

But skb->protocol points to htons(ETH_P_8021Q) and skb_flow_dissect()
looks inside network header, not layer 2 where vlan header resides.

Thats main problem with this. layer2+3 and layer3+4 - original bonding
xmit hash policies also affected by skb->protocol == htons(ETH_P_8021Q)
for stacked vlans.

Thanks for quick answer.

> 
> All is about headers. hdr and _hdr are vague.

Well, 802.1q != 802.1ad, VLAN != VMAN (QinQ, etc.), I consider this, butthis 
is quick patch, no problem with any names. Sorry for this.

Patch only for give a hint on question I ask. Thanks.

-- 
SP5474-RIPE
Sergey Popovich

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html