netdev - [PATCH 02/26] drivers: isdn: Move prototype declaration to header file um_idi.h from um

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a38afb37d39385b9dc4eac5c351b7b46048a873e.1390408513.git.rashika.kheria@gmail.com>
Date:	Fri, 7 Feb 2014 17:49:09 +0530
From:	Rashika Kheria <rashika.kheria@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	Armin Schindler <mac@...ware.de>,
	Karsten Keil <isdn@...ux-pingi.de>, netdev@...r.kernel.org,
	josh@...htriplett.org
Subject: [PATCH 02/26] drivers: isdn: Move prototype declaration to header
 file um_idi.h from um_idi.c

Move prototype declaration of functions to header file
hardware/eicon/um_idi.h because they are used by more than one file.

This eliminates the following warnings in hardware/eicon/divasi.c:
drivers/isdn/hardware/eicon/divasi.c:446:6: warning: no previous prototype for ‘diva_os_wakeup_read’ [-Wmissing-prototypes]
drivers/isdn/hardware/eicon/divasi.c:453:6: warning: no previous prototype for ‘diva_os_wakeup_close’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
Reviewed-by: Josh Triplett <josh@...htriplett.org>
---
 drivers/isdn/hardware/eicon/um_idi.c |    5 -----
 drivers/isdn/hardware/eicon/um_idi.h |    2 ++
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/isdn/hardware/eicon/um_idi.c b/drivers/isdn/hardware/eicon/um_idi.c
index e151971..676663a 100644
--- a/drivers/isdn/hardware/eicon/um_idi.c
+++ b/drivers/isdn/hardware/eicon/um_idi.c
@@ -14,11 +14,6 @@
 #define DIVAS_MAX_XDI_ADAPTERS	64
 
 /* --------------------------------------------------------------------------
-   IMPORTS
-   -------------------------------------------------------------------------- */
-extern void diva_os_wakeup_read(void *os_context);
-extern void diva_os_wakeup_close(void *os_context);
-/* --------------------------------------------------------------------------
    LOCALS
    -------------------------------------------------------------------------- */
 static LIST_HEAD(adapter_q);
diff --git a/drivers/isdn/hardware/eicon/um_idi.h b/drivers/isdn/hardware/eicon/um_idi.h
index ffb88f7..00ca1e7 100644
--- a/drivers/isdn/hardware/eicon/um_idi.h
+++ b/drivers/isdn/hardware/eicon/um_idi.h
@@ -34,6 +34,8 @@ int diva_um_idi_write(void *entity,
 int diva_user_mode_idi_ind_ready(void *entity, void *os_handle);
 void *diva_um_id_get_os_context(void *entity);
 int diva_os_get_context_size(void);
+void diva_os_wakeup_read(void *os_context);
+void diva_os_wakeup_close(void *os_context);
 int divas_um_idi_entity_assigned(void *entity);
 int divas_um_idi_entity_start_remove(void *entity);
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html