lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1391871850.10160.103.camel@edumazet-glaptop2.roam.corp.google.com> Date: Sat, 08 Feb 2014 07:04:10 -0800 From: Eric Dumazet <eric.dumazet@...il.com> To: Thomas Glanzmann <thomas@...nzmann.de> Cc: Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, "Nicholas A. Bellinger" <nab@...ux-iscsi.org>, target-devel <target-devel@...r.kernel.org>, Linux Network Development <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] tcp: disable auto corking by default On Sat, 2014-02-08 at 10:19 +0100, Thomas Glanzmann wrote: > When using auto corking with iSCSI the round trip time at least increases by > factor 25 probably more. Other protocols are very likely also effected. > > Signed-off-by: Thomas Glanzmann <thomas@...nzmann.de> > --- > net/ipv4/tcp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I think there is no hurry. We should let auto corking on during 3.14 development cycle so that we can fix the bugs, and thing of some optimizations. auto cork gives a strong incentive to applications to use TCP_CORK/MSG_MORE to avoid overhead of sending multiple small segments. In the normal case, the extra delay is something like 10 us, so if an application is really hit by this delay, its a strong sign it could be improved, especially if auto corking is off. Lets wait the end of 3.14 dev cycle before considering this patch. Don't shoot the messenger :) Thanks ! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists