netdev - Re: [PATCH] net: vxge: Remove unused device pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Feb 2014 09:01:04 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Christian Engelmayer' <cengelma@....at>,
	'Jon Mason' <jdmason@...zu.us>
Cc:	netdev@...r.kernel.org, 'David Miller' <davem@...emloft.net>,
	'Patrick McHardy' <kaber@...sh.net>,
	'Masanari Iida' <standby24x7@...il.com>,
	'John Stultz' <john.stultz@...aro.org>,
	'dingtianhong' <dingtianhong@...wei.com>,
	'Ben Hutchings' <bhutchings@...arflare.com>,
	'stephen hemminger' <stephen@...workplumber.org>,
	'Tom Herbert' <therbert@...gle.com>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH] net: vxge: Remove unused device pointer

On Sunday, February 09, 2014 8:16 AM, Christian Engelmayer wrote:
> 
> Remove occurrences of unused struct __vxge_hw_device pointer in functions
> vxge_learn_mac() and vxge_rem_isr().
> 
> Detected by Coverity: CID 139839, CID 139842.
> 
> Signed-off-by: Christian Engelmayer <cengelma@....at>

Reviewed-by: Jingoo Han <jg1.han@...sung.com>

Best regards,
Jingoo Han

> ---
>  drivers/net/ethernet/neterion/vxge/vxge-main.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-
> main.c
> index 1ded50ca..e46e869 100644
> --- a/drivers/net/ethernet/neterion/vxge/vxge-main.c
> +++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c
> @@ -726,9 +726,6 @@ static int vxge_learn_mac(struct vxgedev *vdev, u8 *mac_header)
>  	int vpath_idx = 0;
>  	enum vxge_hw_status status = VXGE_HW_OK;
>  	struct vxge_vpath *vpath = NULL;
> -	struct __vxge_hw_device *hldev;
> -
> -	hldev = pci_get_drvdata(vdev->pdev);
> 
>  	mac_address = (u8 *)&mac_addr;
>  	memcpy(mac_address, mac_header, ETH_ALEN);
> @@ -2443,9 +2440,6 @@ static void vxge_rem_msix_isr(struct vxgedev *vdev)
> 
>  static void vxge_rem_isr(struct vxgedev *vdev)
>  {
> -	struct __vxge_hw_device *hldev;
> -	hldev = pci_get_drvdata(vdev->pdev);
> -
>  #ifdef CONFIG_PCI_MSI
>  	if (vdev->config.intr_type == MSI_X) {
>  		vxge_rem_msix_isr(vdev);
> --
> 1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html