lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAAfyv354SPRvqmN-AO0GmwNVcDG-6Pxenn8_gt+ta8HY8kJ9vQ@mail.gmail.com> Date: Mon, 10 Feb 2014 21:05:31 +0100 From: Belisko Marek <marek.belisko@...il.com> To: "Dr. H. Nikolaus Schaller" <hns@...delico.com> Cc: Johannes Berg <johannes@...solutions.net>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, "ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Rob Landley <rob@...dley.net>, "John W. Linville" <linville@...driver.com>, David Miller <davem@...emloft.net>, Grant Likely <grant.likely@...aro.org>, NeilBrown Brown <neilb@...e.de>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, linux-wireless@...r.kernel.org, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH] net: rfkill-regulator: Add devicetree support. On Mon, Feb 10, 2014 at 9:54 AM, Dr. H. Nikolaus Schaller <hns@...delico.com> wrote: > Am 10.02.2014 um 09:27 schrieb Johannes Berg: > >> On Fri, 2014-02-07 at 20:48 +0100, Marek Belisko wrote: >> >>> +#define RFKILL_TYPE_ALL (0) >>> +#define RFKILL_TYPE_WLAN (1) >>> +#define RFKILL_TYPE_BLUETOOTH (2) >>> +#define RFKILL_TYPE_UWB (3) >>> +#define RFKILL_TYPE_WIMAX (4) >>> +#define RFKILL_TYPE_WWAN (5) >>> +#define RFKILL_TYPE_GPS (6) >>> +#define RFKILL_TYPE_FM (7) >>> +#define RFKILL_TYPE_NFC (8) >> >> This seems like a bad idea since there's an enum elsewhere in userspace >> API already. I know this is duplicate but in device tree we cannot use enums (AFAIU include/dt-bindings are defines used in device tree files) > > Yes, > you are right. It is defined in include/uapi/linux/rfkill.h > > Tnx, > Nikolaus > BR, marek -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite twitter: #opennandra web: http://open-nandra.com -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists