netdev - Re: [PATCH] iproute: Properly handle protocol level diag module absence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140210143731.34b73a78@nehalam.linuxnetplumber.net>
Date:	Mon, 10 Feb 2014 14:37:31 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Pavel Emelyanov <xemul@...allels.com>
Cc:	Stephen Hemminger <shemminger@...ux-foundation.org>,
	Linux Netdev List <netdev@...r.kernel.org>,
	François-Xavier Le Bail 
	<fx.lebail@...oo.com>
Subject: Re: [PATCH] iproute: Properly handle protocol level diag module
 absence

On Tue, 28 Jan 2014 21:32:00 +0400
Pavel Emelyanov <xemul@...allels.com> wrote:

> When *_diag module is missing in the kernel, the ss tool should go
> ad read legacry /proc/* files.
> 
> This is the case when all *_diag stuff is missing, but in case the
> inet_diag.ko is loaded, but (tcp|udp)_diag.ko is not, the ss tool
> doesn't notice this and produces empty output. The reason for that
> is -- error from the inet_diag module (which means, that e.g. the
> udp_diag is missing) is reported in the NLMSG_DONE message body.
> 
> That said, we need to check the NLMSG_DONE's message return code
> and act respectively.
> 
> Reported-by: François-Xavier Le Bail <fx.lebail@...oo.com>
> Signed-off-by: Pavel Emelyanov <xemul@...allels.com>
> 

Silently ignoring the error seems wrong.
The fallback is good, but we should try and report the error so that
the user fixes the kernel config.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html