lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20140210.144054.2066120014050984537.davem@davemloft.net> Date: Mon, 10 Feb 2014 14:40:54 -0800 (PST) From: David Miller <davem@...emloft.net> To: srinivas.kandagatla@...com Cc: netdev@...r.kernel.org, robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com, ijc+devicetree@...lion.org.uk, galak@...eaurora.org, rob@...dley.net, linux@....linux.org.uk, stuart.menefy@...com, peppe.cavallaro@...com, devicetree@...r.kernel.org, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, kernel@...inux.com Subject: Re: [PATCH v2 1/3] net: stmmac:sti: Add STi SOC glue driver. From: <srinivas.kandagatla@...com> Date: Fri, 7 Feb 2014 10:55:25 +0000 > + if (dwmac->interface == PHY_INTERFACE_MODE_MII || > + dwmac->interface == PHY_INTERFACE_MODE_GMII) { This is not indented correctly, the first character on the second line should line up exactly at the column after the openning parenthesis on the first line. The objective is not to indent using only TAB characters, which you are doing here. Rather, the objective is to use the appropriate number of TAB _and_ space characters necessary to reach the proper column. > + const char *rs; > + err = of_property_read_string(np, "st,tx-retime-src", &rs); Please add an empty line after the local variable declaration. > + if (!strcasecmp(rs, "clk_125")) > + dwmac->is_tx_retime_src_clk_125 = true; > + > + } That empty line is superfluous, please delete it. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists