lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140210084925.GD1205@redhat.com> Date: Mon, 10 Feb 2014 09:49:26 +0100 From: Veaceslav Falico <vfalico@...hat.com> To: Ding Tianhong <dingtianhong@...wei.com> Cc: Jay Vosburgh <fubar@...ibm.com>, Andy Gospodarek <andy@...yhouse.net>, "David S. Miller" <davem@...emloft.net>, Netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net] bonding: remove unwanted bond lock for enslave processing On Mon, Feb 10, 2014 at 04:33:59PM +0800, Ding Tianhong wrote: >The bond enslave processing don't hold bond->lock anymore, >so release an unlocked rw lock will cause warning message, >remove the unwanted read_unlock(&bond->lock). > >Cc: Jay Vosburgh <fubar@...ibm.com> >Cc: Veaceslav Falico <vfalico@...hat.com> >Cc: Andy Gospodarek <andy@...yhouse.net> >Signed-off-by: Ding Tianhong <dingtianhong@...wei.com> Good catch. Acked-by: Veaceslav Falico <vfalico@...hat.com> >--- > drivers/net/bonding/bond_main.c | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c >index a7db819..ccfb998 100644 >--- a/drivers/net/bonding/bond_main.c >+++ b/drivers/net/bonding/bond_main.c >@@ -1505,7 +1505,6 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev) > slave_dev->npinfo = bond->dev->npinfo; > if (slave_dev->npinfo) { > if (slave_enable_netpoll(new_slave)) { >- read_unlock(&bond->lock); > pr_info("Error, %s: master_dev is using netpoll, " > "but new slave device does not support netpoll.\n", > bond_dev->name); >-- >1.8.0 > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists