lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20140209.181309.693568109095582800.davem@davemloft.net> Date: Sun, 09 Feb 2014 18:13:09 -0800 (PST) From: David Miller <davem@...emloft.net> To: fx.lebail@...oo.com Cc: netdev@...r.kernel.org, nicolas.dichtel@...nd.com Subject: Re: [PATCH] ipv6: icmp6_send: fix Oops when pinging a not set up IPv6 peer on a sit tunnel From: Francois-Xavier Le Bail <fx.lebail@...oo.com> Date: Fri, 7 Feb 2014 11:22:37 +0100 > The patch 446fab59333dea91e54688f033dd8d788d0486fb ("ipv6: enable anycast addresses > as source addresses in ICMPv6 error messages") causes an Oops when pinging a not > set up IPv6 peer on a sit tunnel. > > The problem is that ipv6_anycast_destination() uses unconditionally skb_dst(skb), > which is NULL in this case. > > The solution is to use instead the ipv6_chk_acast_addr_src() function. > > Here are the steps to reproduce it: > modprobe sit > ip link add sit1 type sit remote 10.16.0.121 local 10.16.0.249 > ip l s sit1 up > ip -6 a a dev sit1 2001:1234::123 remote 2001:1234::121 > ping6 2001:1234::121 > > Reported-by: Nicolas Dichtel <nicolas.dichtel@...nd.com> > Tested-by: Nicolas Dichtel <nicolas.dichtel@...nd.com> > Signed-off-by: Francois-Xavier Le Bail <fx.lebail@...oo.com> Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists