lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Feb 2014 10:16:26 -0800 From: Eric Dumazet <eric.dumazet@...il.com> To: Alexander Aring <alex.aring@...il.com> Cc: netdev@...r.kernel.org, linux-zigbee-devel@...ts.sourceforge.net Subject: Re: 6lowpan: lockless tx queue of routing netlink device On Mon, 2014-02-10 at 18:33 +0100, Alexander Aring wrote: > Hi Eric, > > On Sun, Feb 09, 2014 at 04:41:47AM -0800, Eric Dumazet wrote: > > > > Please try the following fix, thanks for this report ! > > > > diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c > > index 48b25c0af4d0..069af33013c4 100644 > > --- a/net/ieee802154/6lowpan.c > > +++ b/net/ieee802154/6lowpan.c > > @@ -533,7 +533,27 @@ static struct header_ops lowpan_header_ops = { > > .create = lowpan_header_create, > > }; > > > > +static struct lock_class_key lowpan_tx_busylock; > > +static struct lock_class_key lowpan_netdev_xmit_lock_key; > > + > > +static void lowpan_set_lockdep_class_one(struct net_device *dev, > > + struct netdev_queue *txq, > > + void *_unused) > > +{ > > + lockdep_set_class(&txq->_xmit_lock, > > + &lowpan_netdev_xmit_lock_key); > > +} > > + > > + > > +static int lowpan_dev_init(struct net_device *dev) > > +{ > > + netdev_for_each_tx_queue(dev, lowpan_set_lockdep_class_one, NULL); > > + dev->qdisc_tx_busylock = &lowpan_tx_busylock; > > + return 0; > > +} > > + > > static const struct net_device_ops lowpan_netdev_ops = { > > + .ndo_init = lowpan_dev_init, > > .ndo_start_xmit = lowpan_xmit, > > .ndo_set_mac_address = lowpan_set_address, > > }; > > thanks, this fixed the issue. What we should do as next? > > Should I create a patch for this or do you want to make a patch? I'll take care of this, don't worry ;) Thanks for testing ! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists