netdev - Re: [PATCH iproute2 net-next-for-3.13 1/2] iplink: display slave information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140210182459.GA26569@unicorn.suse.cz>
Date:	Mon, 10 Feb 2014 19:24:59 +0100
From:	Michal Kubecek <mkubecek@...e.cz>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 net-next-for-3.13 1/2] iplink: display slave
 information

On Mon, Feb 10, 2014 at 09:09:16AM -0800, Stephen Hemminger wrote:
> On Mon, 10 Feb 2014 09:11:46 +0100 (CET)
> Michal Kubecek <mkubecek@...e.cz> wrote:
> 
> > +	if (1) {
> > +		struct rtattr *attr[lu->maxslattr+1], **data = NULL;
> > +
> > +		if (linkinfo[IFLA_INFO_SLAVE_DATA]) {
> > +			parse_rtattr_nested(attr, lu->maxslattr,
> > +					    linkinfo[IFLA_INFO_SLAVE_DATA]);
> > +			data = attr;
> > +		}
> > +		lu->print_slave_opt(lu, fp, data);
> > +	}
> >  }
> 
> Ugly, please don't use if (1)

Normally I woudn't but it was already there this way in the original
code so I assumed there was a reason for that (even if I couldn't see
an obvious one).

Should I send a v2 or are you going to use the implementation submitted
by Jiri Pirko?

                                                       Michal Kubecek

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html