lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Feb 2014 12:07:53 -0500 From: Jamal Hadi Salim <jhs@...atatu.com> To: vyasevic@...hat.com, "netdev@...r.kernel.org" <netdev@...r.kernel.org> CC: Stephen Hemminger <stephen@...workplumber.org>, Scott Feldman <sfeldma@...ulusnetworks.com>, John Fastabend <john.r.fastabend@...el.com> Subject: Re: RFC: bridge get fdb by bridge device On 02/10/14 11:31, Vlad Yasevich wrote: > On 02/09/2014 10:06 AM, Jamal Hadi Salim wrote: >> + ndm = nlmsg_data(cb->nlh); >> + if (ndm->ndm_ifindex) { > > We get really lucky here that ndm_ifindex and ifi_index happen to map to > the same location. > Didnt follow - but I have a feeling you are looking at the reference point of a bridge port. Note as per my response to John: The target is a bridge device, not a bridge port. > > I agree with both of Johns commens fro the above code. > I think you can use ndo_dflt_fdb_dump() here and remove the first check > for IFF_EBRIDGE. > Same comment i made to John. The goal is to emulate brctl showmacs <bridge> ndo_dflt_fdb_dump() gives me in theory all the bridge ports unicast and multicast MAC addresses. There is a posibility that the bridgeport is a bridge - in which case I can find out from user space and safely request for it directly instead of via its parent. > The only odd thing is that it would permit syntax like: > # bridge fbd show br eth0 > or > # bridge fdb show br macvlan0 > > but I think that's ok. Ok, since both you and John point to macvlan - is that considered as something with an fdb? It doesnt forward packets between two devices. >> diff --git a/bridge/fdb.c b/bridge/fdb.c >> index e2e53f1..f3073d6 100644 >> --- a/bridge/fdb.c >> +++ b/bridge/fdb.c >> @@ -33,7 +33,7 @@ static void usage(void) >> fprintf(stderr, "Usage: bridge fdb { add | append | del | replace } > ADDR dev DEV {self|master} [ temp ]\n" >> " [router] [ dst IPADDR] [ vlan VID ]\n" >> " [ port PORT] [ vni VNI ] [via DEV]\n"); >> - fprintf(stderr, " bridge fdb {show} [ dev DEV ]\n"); >> + fprintf(stderr, " bridge fdb {show} [ br BRDEV ] [ dev DEV ]\n"); > > 'port' option is now allowed in the show operation > Thanks - it is already taken seems by vxlan using the same interface. cheers, jamal -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists