netdev - Re: [PATCH net-next] net: remove useless if check from register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140212.094611.946835062678856302.davem@davemloft.net>
Date:	Wed, 12 Feb 2014 09:46:11 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	kda@...ux-powerpc.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: remove useless if check from
 register_netdevice()

From: Denis Kirjanov <kda@...ux-powerpc.org>
Date: Wed, 12 Feb 2014 11:45:52 +0400

> @@ -5876,8 +5876,7 @@ int register_netdevice(struct net_device *dev)
>  	if (dev->netdev_ops->ndo_init) {
>  		ret = dev->netdev_ops->ndo_init(dev);
>  		if (ret) {
> -			if (ret > 0)
> -				ret = -EIO;
> +            ret = -EIO;
>  			goto out;
>  		}

Like your other patch you are not formatting this code properly at all.

If you cannot insert the correct TAB and space characters necessary
to indent the code properly, have something help you do it, such as
emacs's C-mode in "linux" mode.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html