| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1392188330-17208-3-git-send-email-dingtianhong@huawei.com> Date: Wed, 12 Feb 2014 14:58:50 +0800 From: Ding Tianhong <dingtianhong@...wei.com> To: <fubar@...ibm.com>, <vfalico@...hat.com>, <andy@...yhouse.net> CC: <davem@...emloft.net>, <netdev@...r.kernel.org> Subject: [PATCH net-next 2/2] bonding: remove the redundant judgements for bond_option_queue_id_set() The dev_valid_name() will check the buffer length for input name, no need to check it twice. Cc: Jay Vosburgh <fubar@...ibm.com> Cc: Veaceslav Falico <vfalico@...hat.com> Cc: Andy Gospodarek <andy@...yhouse.net> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com> --- drivers/net/bonding/bond_options.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c index 11cb943..832d6e9 100644 --- a/drivers/net/bonding/bond_options.c +++ b/drivers/net/bonding/bond_options.c @@ -1199,8 +1199,7 @@ int bond_option_queue_id_set(struct bonding *bond, goto err_no_cmd; /* Check buffer length, valid ifname and queue id */ - if (strlen(newval->string) > IFNAMSIZ || - !dev_valid_name(newval->string) || + if (!dev_valid_name(newval->string) || qid > bond->dev->real_num_tx_queues) goto err_no_cmd; -- 1.8.0 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists