netdev - Re: [net-next 5/5] ixgbe: fixup warning regarding max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Feb 2014 15:20:38 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ben@...adent.org.uk
Cc:	aaron.f.brown@...el.com, jacob.e.keller@...el.com,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next 5/5] ixgbe: fixup warning regarding max_vfs parameter

From: Ben Hutchings <ben@...adent.org.uk>
Date: Thu, 13 Feb 2014 20:01:32 +0000

> On Thu, 2014-02-13 at 00:00 -0800, Aaron Brown wrote:
>> From: Jacob Keller <jacob.e.keller@...el.com>
>> 
>> The max_vfs parameter for ixgbe is deprecated in favor of using the
>> sysfs sriov_numvfs field to assign VFs as needed, instead of fixing the
>> value at module load time. The current message only indicates that you
>> should use this, without adequately explaining how to do so.
> 
> I don't think the kernel log is the correct place to put documentation.
> A reference alone should be enough.
> 
> [...]
>> +               e_dev_warn("See 'Documentation/PCI/pci-iov-howto.txt for more information.\n");
> [...]
> 
> This doesn't seem very helpful to non-developers.  You could instead
> give the URL:
> 
> https://www.kernel.org/doc/Documentation/PCI/pci-iov-howto.txt

I even think this is not desirable.  The kernel log isn't supposed to be
a hyper-linked "all the information you could possibly need" repository
for every interesting situation the kernel encounters.

Just say plainly what the problem is, people need a certainly level of
understanding to interpret kernel messages properly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html