netdev - Re: [PATCH 1/2] net: core: introduce netif_skb_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 13 Feb 2014 15:43:47 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	fw@...len.de
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] net: core: introduce netif_skb_dev_features

From: Florian Westphal <fw@...len.de>
Date: Mon, 10 Feb 2014 21:35:36 +0100

> @@ -2495,34 +2495,36 @@ static int dev_gso_segment(struct sk_buff *skb, netdev_features_t features)
>  }
>  
>  static netdev_features_t harmonize_features(struct sk_buff *skb,
> -	netdev_features_t features)
> +					    const struct net_device *dev,
> +					    netdev_features_t features)
 ...
> -	} else if (illegal_highdma(skb->dev, skb)) {
> +	} else if (illegal_highdma(dev, skb)) {

illegal_highdma() is not prepared to take a "const struct net_device *",
you must have seen the warning in your build.  At least I did.

Please fix this and resubmit this series, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html