netdev - Re: [PATCH net] bonding: Fix deadlock in bonding driver when using netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140213.171357.1018720142829787554.davem@davemloft.net>
Date:	Thu, 13 Feb 2014 17:13:57 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dingtianhong@...wei.com
Cc:	fubar@...ibm.com, vfalico@...hat.com, andy@...yhouse.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH net] bonding: Fix deadlock in bonding driver when using
 netpoll

From: Ding Tianhong <dingtianhong@...wei.com>
Date: Wed, 12 Feb 2014 12:06:40 +0800

> The bonding driver take write locks and spin locks that are shared
> by the tx path in enslave processing and notification processing,
> If the netconsole is in use, the bonding can call printk which puts
> us in the netpoll tx path, if the netconsole is attached to the bonding
> driver, result in deadlock.
> 
> So add protection for these place, by checking the netpoll_block_tx
> state, we can defer the sending of the netconsole frames until a later
> time using the retransmit feature of netpoll_send_skb that is triggered
> on the return code NETDEV_TX_BUSY.
> 
> Cc: Jay Vosburgh <fubar@...ibm.com>
> Cc: Veaceslav Falico <vfalico@...hat.com>
> Cc: Andy Gospodarek <andy@...yhouse.net>
> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html