netdev - Re: [PATCH net 1/3] kref: add kref_sub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140213012548.GA20953@logfs.org>
Date:	Wed, 12 Feb 2014 20:25:48 -0500
From:	Jörn Engel <joern@...fs.org>
To:	David Miller <davem@...emloft.net>
Cc:	gregkh@...uxfoundation.org, mst@...hat.com,
	linux-kernel@...r.kernel.org, jasowang@...hat.com,
	virtio-dev@...ts.oasis-open.org,
	virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
	qinchuanyu@...wei.com, anatol.pomozov@...il.com,
	nab@...ux-iscsi.org
Subject: Re: [PATCH net 1/3] kref: add kref_sub_return

On Wed, 12 February 2014 19:06:37 -0500, David Miller wrote:
> 
> It isn't being used to determine when to destroy things.
> 
> They use it to as a heuristic of when to trigger polling.
> 
> Each ubuf attached gets a kref to the higher level virtio_net buffer
> holding object, they want to trigger polling when that reference drops
> to 1 or lower.
> 
> Right now they are reading the atomic refcount directly, which
> I think is much worse than this helper.

I disagree.  Reading the refcount directly is leaving noone under any
illusion that this might be a good idea.

Jörn

--
Victory in war is not repetitious.
-- Sun Tzu
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html