netdev - Re: [PATCH net-next v4 00/10] Support for the Broadcom GENET driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140213.183914.1533527602267985176.davem@davemloft.net>
Date:	Thu, 13 Feb 2014 18:39:14 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	cernekee@...il.com, mark.rutland@....com, romieu@...zoreil.com
Subject: Re: [PATCH net-next v4 00/10] Support for the Broadcom GENET driver

From: David Miller <davem@...emloft.net>
Date: Thu, 13 Feb 2014 18:38:06 -0500 (EST)

> From: Florian Fainelli <f.fainelli@...il.com>
> Date: Thu, 13 Feb 2014 15:30:12 -0800
> 
>> This patchset adds support for the Broadcom GENET Gigabit Ethernet MAC
>> controller. This controller is found on the Broadcom BCM7xxx Set Top Box
>> System-on-a-chips.
>> 
>> Changes since v3:
>> - fixed Kconfig dependency on FIXED_PHY
>> 
>> Changes since v2:
>> - dropped the patch that adds an "internal" phy-mode
> 
> Looks better, series applied, thanks.

Actually, I have to revert, this breaks the allmodconfig build on x86_64:

drivers/net/ethernet/broadcom/genet/bcmmii.c: In function ‘bcmgenet_mii_of_init’:
drivers/net/ethernet/broadcom/genet/bcmmii.c:404:2: error: implicit declaration of function ‘of_get_next_child’ [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/genet/bcmmii.c:404:10: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors