netdev - Re: [PATCH net-next v4 00/10] Support for the Broadcom GENET driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Feb 2014 15:42:53 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Kevin Cernekee <cernekee@...il.com>,
	Mark Rutland <mark.rutland@....com>,
	Francois Romieu <romieu@...zoreil.com>
Subject: Re: [PATCH net-next v4 00/10] Support for the Broadcom GENET driver

2014-02-13 15:41 GMT-08:00 Florian Fainelli <f.fainelli@...il.com>:
> 2014-02-13 15:39 GMT-08:00 David Miller <davem@...emloft.net>:
>> From: David Miller <davem@...emloft.net>
>> Date: Thu, 13 Feb 2014 18:38:06 -0500 (EST)
>>
>>> From: Florian Fainelli <f.fainelli@...il.com>
>>> Date: Thu, 13 Feb 2014 15:30:12 -0800
>>>
>>>> This patchset adds support for the Broadcom GENET Gigabit Ethernet MAC
>>>> controller. This controller is found on the Broadcom BCM7xxx Set Top Box
>>>> System-on-a-chips.
>>>>
>>>> Changes since v3:
>>>> - fixed Kconfig dependency on FIXED_PHY
>>>>
>>>> Changes since v2:
>>>> - dropped the patch that adds an "internal" phy-mode
>>>
>>> Looks better, series applied, thanks.
>>
>> Actually, I have to revert, this breaks the allmodconfig build on x86_64:
>>
>> drivers/net/ethernet/broadcom/genet/bcmmii.c: In function ‘bcmgenet_mii_of_init’:
>> drivers/net/ethernet/broadcom/genet/bcmmii.c:404:2: error: implicit declaration of function ‘of_get_next_child’ [-Werror=implicit-function-declaration]
>> drivers/net/ethernet/broadcom/genet/bcmmii.c:404:10: warning: assignment makes pointer from integer without a cast [enabled by default]
>> cc1: some warnings being treated as errors
>
> Ok, would you agree in having a big fat "depends on OF" for now until
> I can get an empty stub going with the DT people?

There is an alternate solution which will not require such a big
hammer Kconfig dependency.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html