netdev - RE: [PATCH net-next 10/14] ethtool: Expand documentation of struct ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Feb 2014 09:17:58 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Ben Hutchings' <ben@...adent.org.uk>,
	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 10/14] ethtool: Expand documentation of struct
 ethtool_stats

From: Of Ben Hutchings
> -/* for dumping NIC-specific statistics */
> +/**
> + * struct ethtool_stats - device-specific statistics
> + * @cmd: Command number = %ETHTOOL_GSTATS
> + * @n_stats: On return, the number of statistics
> + * @data: Array of statistics
> + *
> + * Users must use %ETHTOOL_GSSET_INFO or %ETHTOOL_GDRVINFO to find the
> + * number of statistics that will be returned.  They must allocate a
> + * buffer of the appropriate size (8 * number of statistics)
> + * immediately following this structure.
> + */
>  struct ethtool_stats {
> -	__u32	cmd;		/* ETHTOOL_GSTATS */
> -	__u32	n_stats;	/* number of u64's being returned */
> +	__u32	cmd;
> +	__u32	n_stats;
>  	__u64	data[0];
>  };

Hmmm... Although that allows some script to generate documentation,
for anyone looking at the heeder file it seems a retrograde step.

	David