netdev - Re: [PATCH net-next v2] IPv6: enable bind() to assign an anycast address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Feb 2014 01:16:24 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Francois-Xavier Le Bail <fx.lebail@...oo.com>
Cc:	NETDEV <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>, kuznet@....inr.ac.ru,
	christoph.paasch@...ouvain.be, eric.dumazet@...il.com
Subject: Re: [PATCH net-next v2] IPv6: enable bind() to assign an anycast address

Hi!

[added Cc list from old thread]

On Wed, Feb 12, 2014 at 02:38:51PM +0100, Francois-Xavier Le Bail wrote:
> - Use ipv6_chk_acast_addr_src() in inet6_bind().
> 
> Signed-off-by: Francois-Xavier Le Bail <fx.lebail@...oo.com>

I would agree with the change but would like to see some people from the old
thread about this change to agree with it, too.

> ---
> v2: ipv6_chk_acast_addr_src() was previously added.
> 
>  net/ipv6/af_inet6.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
> index c921d5d..68b81e9 100644
> --- a/net/ipv6/af_inet6.c
> +++ b/net/ipv6/af_inet6.c
> @@ -347,7 +347,9 @@ int inet6_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len)
>  			if (!(addr_type & IPV6_ADDR_MULTICAST))	{
>  				if (!(inet->freebind || inet->transparent) &&
>  				    !ipv6_chk_addr(net, &addr->sin6_addr,
> -						   dev, 0)) {
> +						   dev, 0) &&
> +				    !ipv6_chk_acast_addr_src(net, dev,
> +							     &addr->sin6_addr)) {
>  					err = -EADDRNOTAVAIL;
>  					goto out_unlock;
>  				}

Thanks,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html