| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1392290048.2214.41.camel@joe-AO722> Date: Thu, 13 Feb 2014 03:14:08 -0800 From: Joe Perches <joe@...ches.com> To: Simon Wunderlich <sw@...onwunderlich.de> Cc: netdev@...r.kernel.org, davem@...emloft.net, linux-wireless@...r.kernel.org, mathias.kretschmer@...us.fraunhofer.de Subject: Re: [net-next 3/3] cfg80211: add MPLS and 802.21 classification On Thu, 2014-02-13 at 11:46 +0100, Simon Wunderlich wrote: Hi Simon > > On Wed, 2014-02-12 at 11:53 +0100, Simon Wunderlich wrote: > > > MPLS labels may contain traffic control information, which should be > > > evaluated and used by the wireless subsystem if present. [] > > > diff --git a/net/wireless/util.c b/net/wireless/util.c [] > > > +#include <uapi/linux/mpls.h> > > > > Please try not to #include uapi files. > why not? The packet definition header has been put in UAPI, so I need that > there ... or should we move that to some place else? Other protocol definition > headers like IP, udp, tcp have been defined in uapi to the same way, so I > figured that would be the right position. It seems the practice is to have another include/<net|linux>/mpls.h file that #includes the <uapi/linux/mpls.h> For instance, look at: include/linux/udp.h It does #include <uapi/linux/udp.h> All the other kernel sources use #include <linux/udp.h> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists