netdev - Re: [PATCH net-next v5 09/10] Documentation: add Device tree bindings for Broadcom GENET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Feb 2014 09:36:26 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Mark Rutland <mark.rutland@....com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"cernekee@...il.com" <cernekee@...il.com>,
	"romieu@...zoreil.com" <romieu@...zoreil.com>
Subject: Re: [PATCH net-next v5 09/10] Documentation: add Device tree bindings
 for Broadcom GENET

2014-02-14 2:19 GMT-08:00 Mark Rutland <mark.rutland@....com>:
> On Fri, Feb 14, 2014 at 12:08:50AM +0000, Florian Fainelli wrote:
>> This patch adds the Device Tree bindings for the Broadcom GENET Gigabit
>> Ethernet controller. A bunch of examples are provided to illustrate the
>> versatile aspect of the hardare.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
>> ---
>> Changes in v5:
>> - respin due to the CONFIG_OF dependency fix
>>
>> Changes in v4:
>> - respin due to the Kconfig dependency
>>
>> Changes in v3
>> - improve compatible property description to specify all compatible strings
>>   supported
>> - move MDIO bus node to a separate section, to separate from the properties
>> - detail which exact phy-mode strings are supported and that this refers to
>>   the ePAPR 'phy-connection-type' modes
>> - fixed MDIO bus node compatible string to match what is really provided by
>>   the bootloader and use the same details as for the GENET compatible string
>> - add address-cells and size-cells required properties for the GENET device
>>   tree node
>> - add a better description for the 'fixed-link' property with reference to
>>   existing binding documentation
>> - add a reference to the Ethernet PHY device tree binding
>> - add a description for the interrupts properties
>> - add a documentation for the optional clocks properties
>> - removed unused and deprecated device_type properties
>>
>> Changes in v2:
>> - rebased against net-next/master
>>
>>  .../devicetree/bindings/net/broadcom-bcmgenet.txt  | 121 +++++++++++++++++++++
>>  1 file changed, 121 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt
>>
>> diff --git a/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt b/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt
>> new file mode 100644
>> index 0000000..afd31f9
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt
>> @@ -0,0 +1,121 @@
>> +* Broadcom BCM7xxx Ethernet Controller (GENET)
>> +
>> +Required properties:
>> +- compatible: should contain one of "brcm,genet-v1", "brcm,genet-v2",
>> +  "brcm,genet-v3", "brcm,genet-v4".
>> +- reg: address and length of the register set for the device
>> +- interrupts: must be two cells, the first cell is the general purpose
>> +  interrupt line, while the second cell is the interrupt for the ring
>> +  RX and TX queues operating in ring mode
>> +- phy-mode: String, operation mode of the PHY interface. Supported values are
>> +  "mii", "rgmii", "rgmii-txid", "rev-mii", "moca". Analogous to ePAPR
>> +  "phy-connection-type" values
>> +- address-cells: should be 1
>> +- size-cells: should be 1
>> +
>> +Optional properties:
>> +- clocks: When provided, must be two cells, first one is the main GENET clock
>> +  and the second cell is the Genet Wake-on-LAN clock.
>
> Clocks aren't just cells. They are referred to with phandle +
> clock-specificer pairs.
>
> This doesn't document the names that the driver requests the clocks by.
> Just listing the clocks isn't sufficient, as any dts will have to add a
> clock-names property to get those clocks probed.

I will follow up with a fix for this, thanks!
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html