netdev - suspicious code in net/rxrpc/ar-error.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Feb 2014 21:28:15 -0500
From:	Dave Jones <davej@...hat.com>
To:	netdev@...r.kernel.org
Cc:	dhowells@...hat.com
Subject: suspicious code in net/rxrpc/ar-error.c

While looking through old coverity reports, I came across this..

 84                 if (mtu == 0) {
 85                         /* they didn't give us a size, estimate one */
 86                         if (mtu > 1500) {
 87                                 mtu >>= 1;
 88                                 if (mtu < 1500)
 89                                         mtu = 1500;
 90                         } else {
 91                                 mtu -= 100;
 92                                 if (mtu < peer->hdrsize)
 93                                         mtu = peer->hdrsize + 4;
 94                         }
 95                 }

What was intended here ? Perhaps one of those mtu comparisons should be
comparing peer->mtu ?

	Dave

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html