lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Feb 2014 16:36:07 +0800 From: Yang Yingliang <yangyingliang@...wei.com> To: <netdev@...r.kernel.org> CC: <davem@...emloft.net>, <stephen@...workplumber.org> Subject: [PATCH net-next 4/7] sch_netem: clear old correlation when old qdisc's replaced If we set a netem qdisc with correlation option, while we use "#tc qdisc replace ..." that without correlation option to replace the old qdisc, the old correlation is still there. We need clear old correlation after qdisc's replaced. Signed-off-by: Yang Yingliang <yangyingliang@...wei.com> --- net/sched/sch_netem.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index bb06dd8..33e7cef 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -703,6 +703,13 @@ static void get_correlation(struct netem_sched_data *q, const struct nlattr *att init_crandom(&q->dup_cor, c->dup_corr); } +static void correlation_reset(struct netem_sched_data *q) +{ + memset(&q->delay_cor, 0, sizeof(struct crndstate)); + memset(&q->loss_cor, 0, sizeof(struct crndstate)); + memset(&q->dup_cor, 0, sizeof(struct crndstate)); +} + static void get_reorder(struct netem_sched_data *q, const struct nlattr *attr) { const struct tc_netem_reorder *r = nla_data(attr); @@ -890,6 +897,8 @@ static int netem_change(struct Qdisc *sch, struct nlattr *opt) if (tb[TCA_NETEM_CORR]) get_correlation(q, tb[TCA_NETEM_CORR]); + else + correlation_reset(q); if (tb[TCA_NETEM_REORDER]) get_reorder(q, tb[TCA_NETEM_REORDER]); -- 1.8.0 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists