netdev - Re: [PATCH] netfilter: ipset: move registration message to init from net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 16 Feb 2014 11:21:28 +0100 (CET)
From:	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>
To:	Ilia Mirkin <imirkin@...m.mit.edu>
cc:	netdev@...r.kernel.org, Florian Westphal <fw@...len.de>
Subject: Re: [PATCH] netfilter: ipset: move registration message to init from
 net_init

On Sun, 16 Feb 2014, Ilia Mirkin wrote:

> Commit 1785e8f473 ("netfiler: ipset: Add net namespace for ipset") moved
> the initialization print into net_init, which can get called a lot due
> to namespaces. Move it back into init, reduce to pr_info.
> 
> Signed-off-by: Ilia Mirkin <imirkin@...m.mit.edu>

I applied your patch in the ipset git tree and will submit the usual way 
for kernel inclusion. Thanks!

Best regards,
Jozsef
 
> The description is based on my meager understanding of what's going on. Feel
> free to adjust it to match reality.
> 
>  net/netfilter/ipset/ip_set_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c
> index bac7e01..0fa2d9c 100644
> --- a/net/netfilter/ipset/ip_set_core.c
> +++ b/net/netfilter/ipset/ip_set_core.c
> @@ -1973,7 +1973,6 @@ ip_set_net_init(struct net *net)
>  		return -ENOMEM;
>  	inst->is_deleted = 0;
>  	rcu_assign_pointer(inst->ip_set_list, list);
> -	pr_notice("ip_set: protocol %u\n", IPSET_PROTOCOL);
>  	return 0;
>  }
>  
> @@ -2024,6 +2023,7 @@ ip_set_init(void)
>  		nfnetlink_subsys_unregister(&ip_set_netlink_subsys);
>  		return ret;
>  	}
> +	pr_info("ip_set: protocol %u\n", IPSET_PROTOCOL);
>  	return 0;
>  }


-
E-mail  : kadlec@...ckhole.kfki.hu, kadlecsik.jozsef@...ner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html