netdev - Re: [PATCH net] bonding: fix arp requests sends with isolated routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140217.145635.1123180851794758928.davem@davemloft.net>
Date:	Mon, 17 Feb 2014 14:56:35 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	f.cachereul@...halink.fr
Cc:	fubar@...ibm.com, vfalico@...hat.com, andy@...yhouse.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH net] bonding: fix arp requests sends with isolated
 routes

From: François Cachereul <f.cachereul@...halink.fr>
Date: Fri, 14 Feb 2014 16:59:23 +0100

> Make arp_send_all() try to send arp packets through slave devices event
> if no route to arp_ip_target is found. This is useful when the route
> is in an isolated routing table with routing rule parameters like oif or
> iif in which case ip_route_output() return an error.
> Thus, the arp packet is send without vlan and with the bond ip address
> as sender.
> 
> Signed-off-by: François CACHEREUL <f.cachereul@...halink.fr>
> ---
> This previously worked, the problem was added in 2.6.35 with vlan 0
> added by default when the module 8021q is loaded. Before that no route
> lookup was done if the bond device did not have any vlan. The problem
> now exists event if the module 8021q is not loaded.

I don't like this at all, you're trying to paper over the fact that we
can't set the flow key correctly at this point.

Just assuming the route might be there and trying anyways is not really
acceptable in my opinion.  There's a reason we do a route lookup at all.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html