netdev - Re: [PATCH net-next v2 01/10] ieee802154: add basic support for RF212 to at86rf230 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140217.000946.1808106131846042730.davem@davemloft.net>
Date:	Mon, 17 Feb 2014 00:09:46 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	phoebe.buckheister@...m.fraunhofer.de
Cc:	netdev@...r.kernel.org, linux-zigbee-devel@...ts.sourceforge.net
Subject: Re: [PATCH net-next v2 01/10] ieee802154: add basic support for
 RF212 to at86rf230 driver

From: Phoebe Buckheister <phoebe.buckheister@...m.fraunhofer.de>
Date: Fri, 14 Feb 2014 23:49:23 +0100

> -	if (page != 0 || channel < 11 || channel > 26) {
> +	if (page < 0
> +		|| page > 31
> +		|| !(lp->dev->phy->channels_supported[page] & BIT(channel))) {

This is not indented properly.

The first character on the second and subsequent lines should start
exactly at the first column after the openning parenthesis of the top-level
if() statement.

You must use the appropriate number of TAB and SPACE characters necessary
to achieve this.

In general, if you are indenting using only TAB characters, you are doing
it wrong.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html