netdev - Re: [PATCH ipsec-next v2] ipsec: add support of limited SA dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 18 Feb 2014 06:46:15 +0100
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
CC:	<herbert@...dor.apana.org.au>, <davem@...emloft.net>,
	<netdev@...r.kernel.org>, <fengguang.wu@...el.com>,
	<kbuild-all@...org>
Subject: Re: [PATCH ipsec-next v2] ipsec: add support of limited SA dump

On Fri, Feb 14, 2014 at 03:30:36PM +0100, Nicolas Dichtel wrote:
> The goal of this patch is to allow userland to dump only a part of SA by
> specifying a filter during the dump.
> The kernel is in charge to filter SA, this avoids to generate useless netlink
> traffic (it save also some cpu cycles). This is particularly useful when there
> is a big number of SA set on the system.
> 
> Note that I removed the union in struct xfrm_state_walk to fix a problem on arm.
> struct netlink_callback->args is defined as a array of 6 long and the first long
> is used in xfrm code to flag the cb as initialized. Hence, we must have:
> sizeof(struct xfrm_state_walk) <= sizeof(long) * 5.
> With the union, it was false on arm (sizeof(struct xfrm_state_walk) was
> sizeof(long) * 7), due to the padding.
> In fact, whatever the arch is, this union seems useless, there will be always
> padding after it. Removing it will not increase the size of this struct (and
> reduce it on arm).
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Applied to ipsec-next, thanks Nicolas!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html