netdev - Re: [PATCH net-next] ethtool: Remove inactive code snippet in ethtool_set_rxfh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140218.172606.963581484037616089.davem@davemloft.net>
Date:	Tue, 18 Feb 2014 17:26:06 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	VenkatKumar.Duvvuru@...lex.Com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ethtool: Remove inactive code snippet in
 ethtool_set_rxfh_indir

From: Venkata Duvvuru <VenkatKumar.Duvvuru@...lex.Com>
Date: Tue, 18 Feb 2014 07:38:28 +0000

> ethtool_rxfh_indir_default is invoked inside ethtool_get_rxfh_indir when user_size is zero. However user_size can only be zero when dev_size is zero in which case ethtool_get_rxfh_indir itself would have returned -EOPNOTSUPP error. User_size = 0 can never occur unless a buggy ethtool sends user_size as zero beforing invoking the ioctl in which case we should return -EINVAL.

Please properly format your commit message, with newlines every ~80 columns.

> Signed-off-by: Venkat Duvvuru <VenkatKumar.Duvvuru@...lex.com>

Also your patch was corrupted in transit, look at what happened when it hit
patchwork:

	http://patchwork.ozlabs.org/patch/321313/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html