netdev - Re: [PATCH] NET: fec: only enable napi if we are successful

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140218.180730.54681622364091114.davem@davemloft.net>
Date:	Tue, 18 Feb 2014 18:07:30 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	rmk+kernel@....linux.org.uk
Cc:	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	dmalek@....net, gerg@...pgear.com, phdm@...qel.be,
	fabio.estevam@...escale.com
Subject: Re: [PATCH] NET: fec: only enable napi if we are successful

From: Russell King <rmk+kernel@....linux.org.uk>
Date: Tue, 18 Feb 2014 12:55:42 +0000

> If napi is left enabled after a failed attempt to bring the interface
> up, we BUG:
> 
> fec 2188000.ethernet eth0: no PHY, assuming direct connection to switch
> libphy: PHY fixed-0:00 not found
> fec 2188000.ethernet eth0: could not attach to PHY
> ------------[ cut here ]------------
> kernel BUG at include/linux/netdevice.h:502!
> Internal error: Oops - BUG: 0 [#1] SMP ARM
> ...
> PC is at fec_enet_open+0x4d0/0x500
> LR is at __dev_open+0xa4/0xfc
> 
> Only enable napi after we are past all the failure paths.
> 
> Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>

Applied, thanks a lot Russell.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html