netdev - Re: [PATCH] ethtool: check the ethtool_ops is NULL in dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5302B57A.1040806@huawei.com>
Date:	Tue, 18 Feb 2014 09:20:58 +0800
From:	Wang Weidong <wangweidong1@...wei.com>
To:	Daniel Borkmann <dborkman@...hat.com>
CC:	David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] ethtool: check the ethtool_ops is NULL in dev_ethtool

On 2014/2/18 1:09, Daniel Borkmann wrote:
> On 02/17/2014 12:31 PM, Wang Weidong wrote:
>> some drivers maybe not implement the ethtool_ops with only
>> set NULL. So when call the ethtool cmds will lead to a
>> 'NULL pointer dereference'.
>>
>> So add a checking in dev_ethtool.
>>
>> Signed-off-by: Wang Weidong <wangweidong1@...wei.com>
>> ---
>>   net/core/ethtool.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
>> index 30071de..f418dcb 100644
>> --- a/net/core/ethtool.c
>> +++ b/net/core/ethtool.c
>> @@ -1499,6 +1499,9 @@ int dev_ethtool(struct net *net, struct ifreq *ifr)
>>           if (!ns_capable(net->user_ns, CAP_NET_ADMIN))
>>               return -EPERM;
>>       }
>> +   
> 
> You have a trailing whitespace/tab in the line above. Please
> use checkpatch for detecting such things.
> 
Sorry for that. I will fix it soon.

> Can you be more specific with "some drivers"? Any driver that
> is in the mainline tree?
> 
No. My team implements a driver without considering the ethtool_ops.
So I got the problem.

>> +    if (!dev->ethtool_ops)
>> +        return -EOPNOTSUPP;
>>
>>       if (dev->ethtool_ops->begin) {
>>           rc = dev->ethtool_ops->begin(dev);
>>
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html