netdev - Re: [PATCH v2] ethtool: check the ethtool_ops is NULL in dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <530338D4.80801@huawei.com>
Date:	Tue, 18 Feb 2014 18:41:24 +0800
From:	Wang Weidong <wangweidong1@...wei.com>
To:	David Miller <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, Daniel Borkmann <dborkman@...hat.com>
Subject: Re: [PATCH v2] ethtool: check the ethtool_ops is NULL in dev_ethtool

Just ignore it.

Regards
Wang

On 2014/2/18 9:42, Wang Weidong wrote:
> some drivers maybe not implement the ethtool_ops with only
> set NULL to ethtool_ops. So when call the ethtool devx will
> lead to a 'NULL pointer dereference'.
> 
> So add a check in dev_ethtool
> 
> Signed-off-by: Wang Weidong <wangweidong1@...wei.com>
> ---
> Change note:
> 
> v2: fix a trailing whitespace/tab pointed out by Daniel
> 
> ---
>  net/core/ethtool.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
> index 30071de..c8cfd8f 100644
> --- a/net/core/ethtool.c
> +++ b/net/core/ethtool.c
> @@ -1500,6 +1500,9 @@ int dev_ethtool(struct net *net, struct ifreq *ifr)
>  			return -EPERM;
>  	}
>  
> +	if (!dev->ethtool_ops)
> +		return -EOPNOTSUPP;
> +
>  	if (dev->ethtool_ops->begin) {
>  		rc = dev->ethtool_ops->begin(dev);
>  		if (rc  < 0)
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html