netdev - Re: [PATCH next resend] tcp: use zero-window when free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140219.163651.1448300228306057162.davem@davemloft.net>
Date:	Wed, 19 Feb 2014 16:36:51 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	fw@...len.de, netdev@...r.kernel.org, ncardwell@...gle.com,
	ycheng@...gle.com
Subject: Re: [PATCH next resend] tcp: use zero-window when free_space is low

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 18 Feb 2014 15:12:13 -0800

> On Tue, 2014-02-18 at 09:30 -0800, Eric Dumazet wrote:
>> On Mon, 2014-02-17 at 21:52 +0100, Florian Westphal wrote:
>> > David Miller <davem@...emloft.net> wrote:
>> > > From: Florian Westphal <fw@...len.de>
>> > > Date: Thu, 13 Feb 2014 12:52:30 +0100
>> > > 
>> > > >  V1 of this patch was deferred, resending to get discussion going again.
>> > > >  Changes since v1:
>> > > >   - add reproducer to commit message
>> > > > 
>> > > >  Unfortunately I couldn't come up with something that has no magic
>> > > >  ('allowed >> 4') value.  I chose >>4 (1/16th) because it didn't cause
>> > > >  tput limitations in my 'full-mss-sized, steady state' netcat tests.
>> > > > 
>> > > >  Maybe someone has better idea?
>> > > 
>> > > I know this is going to be frustrating, but I've marked this 'deferred'
>> > > again.  Please resubmit after the testing and further discussions have
>> > > been worked out.
>> > 
>> > Thanks for letting me know.  I understand why you are reluctant to just
>> > apply this.
>> > 
>> > I will submit another patch shortly that introduces snmp counter for zero-window
>> > (what Eric suggested), perhaps it helps him or others to find a better solution
>> > in the scenario.
>> 
>> Sorry for the delay guys, I was on vacation.
>> 
>> I started the tests this morning, results in about 2/3 hours.
> 
> No regression found, feel free to add my :
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>
> Tested-by: Eric Dumazet <edumazet@...gle.com>

Florian please resend with Eric's tags and I'll apply.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html