| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140219074633.GA26271@electric-eye.fr.zoreil.com> Date: Wed, 19 Feb 2014 08:46:33 +0100 From: Francois Romieu <romieu@...zoreil.com> To: hayeswang <hayeswang@...ltek.com> Cc: netdev@...r.kernel.org, nic_swsd@...ltek.com, linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org Subject: Re: [PATCH net-next 12/14] r8152: replace netif_rx withnetif_receive_skb hayeswang <hayeswang@...ltek.com> : > Francois Romieu [mailto:romieu@...zoreil.com] > > Hayes Wang <hayeswang@...ltek.com> : > > > Replace netif_rx with netif_receive_skb to avoid disabling irq frequently > > > for increasing the efficiency. > > > > read_bulk_callback is issued in irq context. It could thus use plain > > spin_lock / spin_unlock instead of the irq disabling version. > > The rx_bottom() is called in tasklet, so I just think I could use > netif_receive_skb directly. The netif_rx seems to queue the packet, > and local_irq_disable() would be called before dequeuing the skb. The change in rx_bottom is fine. My point is about read_bulk_callback. rx_bottom races with read_bulk_callback. rx_bottom is issued in tasklet (softirq) context. read_bulk_callback is issued in irq context, with irq disabled. read_bulk_callback does not need to disable irq itself and could go with spin_lock in place of spin_lock_irqsave (rx_bottom can't, of course). -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists