netdev - Re: [PATCH 1/1] net: tcp: RTO restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1392832907.18849.10.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 19 Feb 2014 10:01:47 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Andreas Petlund <apetlund@...ula.no>
Cc:	Per Hurtig <per.hurtig@....se>, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com,
	Anna Brunström <anna.brunstrom@....se>,
	Michael Welzl <michawe@....uio.no>, ilpo.jarvinen@...sinki.fi
Subject: Re: [PATCH 1/1] net: tcp: RTO restart

On Wed, 2014-02-19 at 18:17 +0100, Andreas Petlund wrote:
> I’ve applied and tested the patch on VMs with both 32 bit and 64 bit kernel.
> 
> Acked-by: Andreas Petlund <apetlund@...ula.no>
> Tested-by: Andreas Petlund <apetlund@...ula.no>

Sure the patch applies, but what experimental results did you get ?

My concern is that TCP_SKB_CB(skb)->when doesn't account for sojourn
time in host queues (qdisc and device). 

Note : Missing documentation for this new sysctl.

This patch certainly cannot be applied as is.

Thanks !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html