netdev - Re: [PATCH net] bonding: fix bond_arp_rcv() race of curr_active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140220.132116.2211832039801912191.davem@davemloft.net>
Date:	Thu, 20 Feb 2014 13:21:16 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	vfalico@...hat.com
Cc:	netdev@...r.kernel.org, dingtianhong@...wei.com, fubar@...ibm.com,
	andy@...yhouse.net
Subject: Re: [PATCH net] bonding: fix bond_arp_rcv() race of
 curr_active_slave

From: Veaceslav Falico <vfalico@...hat.com>
Date: Thu, 20 Feb 2014 12:15:19 +0100

> On Thu, Feb 20, 2014 at 12:07:57PM +0100, Veaceslav Falico wrote:
>>bond->curr_active_slave can be changed between its deferences, even to
>>NULL, and thus we might panic.
>>
>>We're always holding the rcu
>>(rx_handler->bond_handle_frame()->bond_arp_rcv())
>>so fix this by rcu_dereferencing() it and using the saved.
>>
>>Reported-by: Ding Tianhong <dingtianhong@...wei.com>
>>Fixes: aeea64a ("bonding: don't trust arp requests unless active slave
>>really works")
>>CC: Jay Vosburgh <fubar@...ibm.com>
>>CC: Andy Gospodarek <andy@...yhouse.net>
>>Signed-off-by: Veaceslav Falico <vfalico@...hat.com>
> 
> Sorry David, it should have been net-next (I've based it on the
> net-next
> tree).
> 
> Can you apply it to net-next or should I resend it?
> 
> Sorry for the noise.

It's fine, applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html