netdev - Re: [PATCH net-next 4/6] 6lowpan: fix some checkpatch issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Feb 2014 18:15:02 +0100
From:	Alexander Aring <alex.aring@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com,
	davem@...emloft.net, linux-zigbee-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org, martin.townsend@...lon.com
Subject: Re: [PATCH net-next 4/6] 6lowpan: fix some checkpatch issues

Hi,

On Fri, Feb 21, 2014 at 08:58:57AM -0800, Joe Perches wrote:
> On Fri, 2014-02-21 at 16:15 +0100, Alexander Aring wrote:
> > diff --git a/net/ieee802154/6lowpan_rtnl.c b/net/ieee802154/6lowpan_rtnl.c
> []
> > @@ -484,8 +475,8 @@ lowpan_skb_fragmentation(struct sk_buff *skb, struct net_device *dev)
> >  		err = lowpan_fragment_xmit(skb, head, header_length, len,
> >  					   offset, LOWPAN_DISPATCH_FRAGN);
> >  		if (err) {
> > -			pr_debug("%s unable to send a subsequent FRAGN packet "
> > -				 "(tag: %d, offset: %d", __func__, tag, offset);
> > +			pr_debug("%s unable to send a FRAGN packet.", __func__);
> > +			pr_debug("tag: %d, offset: %d", tag, offset);
> 
> No need for 2 pr_debug statements.
> 
> Better to coalesce the format pieces into a single string
> adding the close parenthesis and a terminating newline.
> 
> 			pr_debug("%s: unable to send a subsequent FRAGN packet "(tag: %d, offset: %d)\n",
> 				 __func__, tag, offset);
ah ok, thanks I will fix it.

- Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html