netdev - Re: [PATCH v2 net-next] ethtool: Remove inactive code snippet in ethtool_set_rxfh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1393013944.15717.62.camel@deadeye.wl.decadent.org.uk>
Date:	Fri, 21 Feb 2014 20:19:04 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	VenkatKumar.Duvvuru@...lex.Com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] ethtool: Remove inactive code snippet in
 ethtool_set_rxfh_indir

On Fri, 2014-02-21 at 12:14 -0500, David Miller wrote:
> From: Venkata Duvvuru <VenkatKumar.Duvvuru@...lex.Com>
> Date: Fri, 21 Feb 2014 10:28:24 +0000
> 
> > There is no option for --set-rxfh-indir to reset the indirection table.
> 
> But this can be easily added to ethtool.
> 
> My point is that the intention is _clearly_ there to provide this
> facility.

This is indeed intentional, and was added by:

commit 278bc4296bd64ffd1d3913b487dc8a520e423a7a
Author: Ben Hutchings <bhutchings@...arflare.com>
Date:   Thu Dec 15 13:56:49 2011 +0000

    ethtool: Define and apply a default policy for RX flow hash indirection

I can't remember whether I wrote a patch for ethtool to use this feature
but I must have tested it somehow...  The ethtool command isn't the only
user of the ethtool API, in any case.

Ben.

-- 
Ben Hutchings
A free society is one where it is safe to be unpopular. - Adlai Stevenson

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)