netdev - RE: [PATCH V4 net-next 1/5] xen-netback: Factor queue-specific data into queue struct.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9AAE0902D5BC7E449B7C8E4E778ABCD0255399@AMSPEX01CL01.citrite.net>
Date:	Fri, 21 Feb 2014 12:24:52 +0000
From:	Paul Durrant <Paul.Durrant@...rix.com>
To:	Andrew Bennieston <andrew.bennieston@...rix.com>,
	"xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>
CC:	Ian Campbell <Ian.Campbell@...rix.com>,
	Wei Liu <wei.liu2@...rix.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	David Vrabel <david.vrabel@...rix.com>
Subject: RE: [PATCH V4 net-next 1/5] xen-netback: Factor queue-specific data
 into queue struct.

> -----Original Message-----
[snip]
> >
> > Any reason why this is not in xenvif_stats? If  it were there then it would
> not need to be atomic.
> The expectation was that it wouldn't be used very often, so an atomic
> op. here wouldn't hurt. I can move it to xenvif_stats if you'd prefer,
> though. I think the use of an atomic pre-dated the xenvif_stats struct,
> so maybe it makes sense to move it there now.
> 

I think so. Seems odd to leave it out on its own.

  Paul