netdev - Re: [patch net] neigh: fix setting of default gc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140222.000908.1152977118961189337.davem@davemloft.net>
Date:	Sat, 22 Feb 2014 00:09:08 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jiri@...nulli.us
Cc:	netdev@...r.kernel.org, gaofeng@...fujitsu.com,
	hannes@...essinduktion.org, joe@...ches.com, vfalico@...hat.com,
	ffusco@...hat.com
Subject: Re: [patch net] neigh: fix setting of default gc_* values

From: Jiri Pirko <jiri@...nulli.us>
Date: Fri, 21 Feb 2014 14:52:57 +0100

> This patch fixes bug introduced by:
> commit 1d4c8c29841b9991cdf3c7cc4ba7f96a94f104ca
> "neigh: restore old behaviour of default parms values"
> 
> The thing is that in neigh_sysctl_register, extra1 and extra2 which were
> previously set for NEIGH_VAR_GC_* are overwritten. That leads to
> nonsense int limits for gc_* variables. So fix this by not touching
> extra* fields for gc_* variables.
> 
> Signed-off-by: Jiri Pirko <jiri@...nulli.us>

Good catch, applied and queued up for -stable.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html