netdev - Re: [PATCH] net: phy: vitesse: advertise PAUSE frame capabilities on Vitesse PHY drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1393076336.15717.97.camel@deadeye.wl.decadent.org.uk>
Date:	Sat, 22 Feb 2014 13:38:56 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	cristian.bercaru@...escale.com,
	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev@...r.kernel.org, madalin.bucur@...escale.com,
	shaohui.xie@...escale.com, shruti@...escale.com
Subject: Re: [PATCH] net: phy: vitesse: advertise PAUSE frame capabilities
 on Vitesse PHY drivers

On Fri, 2014-02-21 at 18:19 +0200, cristian.bercaru@...escale.com wrote:
> From: Cristian Bercaru <cristian.bercaru@...escale.com>
> 
> Enable the advertisment of symmetric and asymmetric PAUSE frame
> capabilities on all Vitesse PHY drivers.

I don't think this makes sense.  So far as I know, pause frame support
depends only on the MAC, not the PHY.

I realise there are already other PHY drivers setting these flags, but
why should they be added to every PHY driver individually when any
autonegotiating PHY can advertise pause capability?

Ben.

> Signed-off-by: Cristian Bercaru <cristian.bercaru@...escale.com>
> ---
>  drivers/net/phy/vitesse.c | 21 ++++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/phy/vitesse.c b/drivers/net/phy/vitesse.c
> index 14372c6..3124b31 100644
> --- a/drivers/net/phy/vitesse.c
> +++ b/drivers/net/phy/vitesse.c
> @@ -227,7 +227,8 @@ static struct phy_driver vsc82xx_driver[] = {
>  	.phy_id         = PHY_ID_VSC8234,
>  	.name           = "Vitesse VSC8234",
>  	.phy_id_mask    = 0x000ffff0,
> -	.features       = PHY_GBIT_FEATURES,
> +	.features       = PHY_GBIT_FEATURES |
> +			SUPPORTED_Pause | SUPPORTED_Asym_Pause,
>  	.flags          = PHY_HAS_INTERRUPT,
>  	.config_init    = &vsc824x_config_init,
>  	.config_aneg    = &vsc82x4_config_aneg,
> @@ -239,7 +240,8 @@ static struct phy_driver vsc82xx_driver[] = {
>  	.phy_id		= PHY_ID_VSC8244,
>  	.name		= "Vitesse VSC8244",
>  	.phy_id_mask	= 0x000fffc0,
> -	.features	= PHY_GBIT_FEATURES,
> +	.features       = PHY_GBIT_FEATURES |
> +			SUPPORTED_Pause | SUPPORTED_Asym_Pause,
>  	.flags		= PHY_HAS_INTERRUPT,
>  	.config_init	= &vsc824x_config_init,
>  	.config_aneg	= &vsc82x4_config_aneg,
> @@ -251,7 +253,8 @@ static struct phy_driver vsc82xx_driver[] = {
>  	.phy_id		= PHY_ID_VSC8514,
>  	.name		= "Vitesse VSC8514",
>  	.phy_id_mask	= 0x000ffff0,
> -	.features	= PHY_GBIT_FEATURES,
> +	.features       = PHY_GBIT_FEATURES |
> +			SUPPORTED_Pause | SUPPORTED_Asym_Pause,
>  	.flags		= PHY_HAS_INTERRUPT,
>  	.config_init	= &vsc824x_config_init,
>  	.config_aneg	= &vsc82x4_config_aneg,
> @@ -263,7 +266,8 @@ static struct phy_driver vsc82xx_driver[] = {
>  	.phy_id         = PHY_ID_VSC8574,
>  	.name           = "Vitesse VSC8574",
>  	.phy_id_mask    = 0x000ffff0,
> -	.features       = PHY_GBIT_FEATURES,
> +	.features       = PHY_GBIT_FEATURES |
> +			SUPPORTED_Pause | SUPPORTED_Asym_Pause,
>  	.flags          = PHY_HAS_INTERRUPT,
>  	.config_init    = &vsc824x_config_init,
>  	.config_aneg    = &vsc82x4_config_aneg,
> @@ -275,7 +279,8 @@ static struct phy_driver vsc82xx_driver[] = {
>  	.phy_id         = PHY_ID_VSC8662,
>  	.name           = "Vitesse VSC8662",
>  	.phy_id_mask    = 0x000ffff0,
> -	.features       = PHY_GBIT_FEATURES,
> +	.features       = PHY_GBIT_FEATURES |
> +			SUPPORTED_Pause | SUPPORTED_Asym_Pause,
>  	.flags          = PHY_HAS_INTERRUPT,
>  	.config_init    = &vsc824x_config_init,
>  	.config_aneg    = &vsc82x4_config_aneg,
> @@ -288,7 +293,8 @@ static struct phy_driver vsc82xx_driver[] = {
>  	.phy_id		= PHY_ID_VSC8221,
>  	.phy_id_mask	= 0x000ffff0,
>  	.name		= "Vitesse VSC8221",
> -	.features	= PHY_GBIT_FEATURES,
> +	.features       = PHY_GBIT_FEATURES |
> +			SUPPORTED_Pause | SUPPORTED_Asym_Pause,
>  	.flags		= PHY_HAS_INTERRUPT,
>  	.config_init	= &vsc8221_config_init,
>  	.config_aneg	= &genphy_config_aneg,
> @@ -301,7 +307,8 @@ static struct phy_driver vsc82xx_driver[] = {
>  	.phy_id		= PHY_ID_VSC8211,
>  	.phy_id_mask	= 0x000ffff0,
>  	.name		= "Vitesse VSC8211",
> -	.features	= PHY_GBIT_FEATURES,
> +	.features       = PHY_GBIT_FEATURES |
> +			SUPPORTED_Pause | SUPPORTED_Asym_Pause,
>  	.flags		= PHY_HAS_INTERRUPT,
>  	.config_init	= &vsc8221_config_init,
>  	.config_aneg	= &genphy_config_aneg,

-- 
Ben Hutchings
I haven't lost my mind; it's backed up on tape somewhere.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)