netdev - Re: [PATCH net-next 3/6] 6lowpan: move 6lowpan.c to 6lowpan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140222140344.GA1032@omega>
Date:	Sat, 22 Feb 2014 15:03:48 +0100
From:	Alexander Aring <alex.aring@...il.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com,
	davem@...emloft.net, linux-zigbee-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org, martin.townsend@...lon.com
Subject: Re: [PATCH net-next 3/6] 6lowpan: move 6lowpan.c to 6lowpan_rtnl.c

Hi Ben,

thanks for your reply.

On Sat, Feb 22, 2014 at 01:40:52PM +0000, Ben Hutchings wrote:
> On Fri, 2014-02-21 at 16:15 +0100, Alexander Aring wrote:
> > We have a 6lowpan.c file and 6lowpan.ko file. To avoid confusing we
> > should move 6lowpan.c to 6lowpan.ko. Then we can support multiple source
> 
> You put the wrong filename here ^
> 
mhh, I meant here:

Currently we have only one-file supporting like:

obj-$(CONFIG_IEEE802154_6LOWPAN) += 6lowpan.o

It's generate a 6lowpan.ko from a 6lowpan.c file.

Now we need some multiple-file supporting and I change it to:

obj-$(CONFIG_IEEE802154_6LOWPAN) += 6lowpan.o
6lowpan-y := 6lowpan_rtnl.o reassembly.o

to generate a still the 6lowpan.ko module with object files of
6lowpan_rtnl.o (which contains mostly some rtnl callbacks implementations
now) and reassembly.o file.

It's to support multiple files for a module only.

I can't do something like:

obj-$(CONFIG_IEEE802154_6LOWPAN) += 6lowpan.o
6lowpan-y := 6lowpan.o reassembly.o

because I have the same name for 6lowpan.c and 6lowpan.ko.

Is there maybe a better solution for this?

btw.

I also detected:

obj-$(CONFIG_6LOWPAN_IPHC) += 6lowpan_iphc.o

which is a seperate module. (if you selected it as module) but this
makes no sense, we should built it in 6lowpan.ko like:

6lowpan-y := 6lowpan_rtnl.o 6lowpan_iphc.o reassembly.o

aswell.

- Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html