netdev - Re: [PATCH net-next 1/8] cxgb4: Add support to recognize 40G links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1393113574.6823.19.camel@deadeye.wl.decadent.org.uk>
Date:	Sat, 22 Feb 2014 23:59:34 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	Casey Leedom <leedom@...lsio.com>,
	Steve Wise <swise@...ngridcomputing.com>,
	Hariprasad Shenai <hariprasad@...lsio.com>,
	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>, dm@...lsio.com,
	nirranjan@...lsio.com, kumaras@...lsio.com, santosh@...lsio.com
Subject: Re: [PATCH net-next 1/8] cxgb4: Add support to recognize 40G links

On Thu, 2014-02-20 at 11:00 -0800, Florian Fainelli wrote:
> 2014-02-20 10:07 GMT-08:00 Casey Leedom <leedom@...lsio.com>:
> >
> > On 02/19/14 13:12, Steve Wise wrote:
> >>
> >>
> >> You probably should add SPEED_40000 to include/uapi/linux/ethtool.h as
> >> part of this series.
> >
> >
> >   I'm ~pretty sure~ that the "word on the street" was that the community
> > wanted to get away from the SPEED_XXX symbols since they simply represented
> > the values XXX.  Thus they didn't offer any real symbolic isolation from
> > weird constants, etc.  I believe that the old SPEED_XXX values were left in
> > place in order to avoid making tons of changes everywhere ...
> 
> Not quite sure where and when you heard that, it seems a little
> disturbing to add a comment in this patch saying "this I how I should
> fix things" and not do them, especially when this is a one-liner.
[...]

Yeah, the way to fix that is to remove the comments...

Ben.

-- 
Ben Hutchings
I haven't lost my mind; it's backed up on tape somewhere.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)