netdev - Re: [PATCH v2] tcp: reduce the bloat caused by tcp_is_cwnd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQyk_t+5fh1Mt-CGQ-NkDoCrv_Pkh7KYqivXDy1x3Kz18dA@mail.gmail.com>
Date:	Sun, 23 Feb 2014 10:16:29 -0500
From:	Neal Cardwell <ncardwell@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Yuchung Cheng <ycheng@...gle.com>,
	Nandita Dukkipati <nanditad@...gle.com>,
	Van Jacobson <vanj@...gle.com>
Subject: Re: [PATCH v2] tcp: reduce the bloat caused by tcp_is_cwnd_limited()

On Sun, Feb 23, 2014 at 1:25 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
...
> v2: addressed Neal point about keeping first condition.
>
>  net/ipv4/tcp_cong.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/ipv4/tcp_cong.c b/net/ipv4/tcp_cong.c
> index ad37bf18ae4b..2388275adb9b 100644
> --- a/net/ipv4/tcp_cong.c
> +++ b/net/ipv4/tcp_cong.c
> @@ -290,8 +290,7 @@ bool tcp_is_cwnd_limited(const struct sock *sk, u32 in_flight)
>         left = tp->snd_cwnd - in_flight;
>         if (sk_can_gso(sk) &&
>             left * sysctl_tcp_tso_win_divisor < tp->snd_cwnd &&
> -           left * tp->mss_cache < sk->sk_gso_max_size &&
> -           left < sk->sk_gso_max_segs)
> +           left < tp->xmit_size_goal_segs)
>                 return true;
>         return left <= tcp_max_tso_deferred_mss(tp);
>  }

Looks great to me. Thanks!

Acked-by: Neal Cardwell <ncardwell@...gle.com>

neal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html