netdev - Re: [PATCH net-next] tcp: switch rtt estimations to usec resolution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1393178122.2316.50.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Sun, 23 Feb 2014 09:55:22 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Julian Anastasov <ja@....bg>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Yuchung Cheng <ycheng@...gle.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Larry Brakmo <brakmo@...gle.com>
Subject: Re: [PATCH net-next] tcp: switch rtt estimations to usec resolution

On Sun, 2014-02-23 at 09:36 +0200, Julian Anastasov wrote:
> 	Hello,
> 
> On Sat, 22 Feb 2014, Eric Dumazet wrote:
> 
> > From: Eric Dumazet <edumazet@...gle.com>
> > 
> > Upcoming congestion controls for TCP require usec resolution for RTT
> > estimations. Millisecond resolution is simply not enough these days.
> 
> ...
> 
> > --- a/net/ipv4/tcp_metrics.c
> > +++ b/net/ipv4/tcp_metrics.c
> 
> ...
> 
> > @@ -408,10 +395,10 @@ void tcp_update_metrics(struct sock *sk)
> >  	 */
> >  	if (!tcp_metric_locked(tm, TCP_METRIC_RTT)) {
> >  		if (m <= 0)
> > -			rtt = tp->srtt;
> > +			rtt = tp->srtt_us;
> >  		else
> >  			rtt -= (m >> 3);
> > -		tcp_metric_set_msecs(tm, TCP_METRIC_RTT, rtt);
> > +		tcp_metric_set(tm, TCP_METRIC_RTT, rtt);
> 
> 	What is the way to handle this change of
> resolution in TCP_METRICS_ATTR_VALS? The ip tool has
> code in ip/tcp_metrics.c process_msg() that needs to
> know what we get, ms or us. Do we need to add some
> new attribute as flag or version? Or we need to increase
> TCP_METRICS_GENL_VERSION in kernel and to check it in
> process_msg ?

crap... This should have been usec units as we did for tcp_info years
ago.

Solution is to add TCP_METRIC_RTT_US and TCP_METRIC_RTTVAR_US attributes

I'll send a v2

Thanks !



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html